Add diagnostics for DTD service detection failures #257
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Log all registered DTD services when checking for ConnectedApp - Capture and log specific errors instead of silently swallowing exceptions - Add contextual error messages explaining possible causes - Track VM service retrieval failures separately - Make error messages dynamic based on actual failure reason
This reverts commit 9b6305b.
jakemac53
reviewed
Aug 4, 2025
| CallToolResult get _connectedAppsNotSupported { | ||
| String errorText; | ||
| if (_serviceDetectionError != null) { | ||
| errorText = 'ConnectedApp service not available: $_serviceDetectionError'; |
There was a problem hiding this comment.
Note that in this case it is usually going to be because the user isn't on the required SDK version, so it would be good to include that in the text here?
|
@lukemmtt if you would like to land this feel free to move it out of draft, it seems pretty landable to me. |
PR HealthChangelog Entry ✔️
Changes to files need to be accounted for in their respective changelogs. |
|
See the errors, just some simple analysis lints to fix :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds error logging to help diagnose DTD connection issues reported in #256.
Changes:
This will help identify why the ConnectedApp service detection is failing for some users.