Enable Travis-CI #7
Conversation
.travis.yml
Outdated
| - test: --platform vm | ||
| # No parallelism on Firefox (-j 1) | ||
| # Causes flakiness – need to investigate | ||
| - test: --platform firefox -j 1 |
There was a problem hiding this comment.
Why Firefox? I thought most of our other packages used Chrome.
The tests on this package are fast enough that it's probably more efficient to run browser and VM tests in the same job.
.travis.yml
Outdated
| dart_task: | ||
| - test: --platform vm | ||
| # No parallelism on Firefox (-j 1) | ||
| # Causes flakiness – need to investigate |
There was a problem hiding this comment.
This should have an assigned TODO.
.travis.yml
Outdated
| # No parallelism on Firefox (-j 1) | ||
| # Causes flakiness – need to investigate | ||
| - test: --platform firefox -j 1 | ||
| - dartanalyzer |
There was a problem hiding this comment.
I'd put this under matrix.include as well. I don't think there's likely to be a lot of value in double-testing analysis.
There was a problem hiding this comment.
As long as stable is supported, I think it's good to track – help find potential API changes that are not backwards compatible.
There was a problem hiding this comment.
We already get that from testing on stable. This package isn't doing anything statically complex enough to be worth the extra job time from this task.
Fixes dart-lang/string_scanner#6
Fixes dart-lang/tools#1790