This repository was archived by the owner on Nov 1, 2024. It is now read-only.
Add write() and writeCharCode() to Logger #42
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CC @pq, @devoncarew might one of you have to review? The migration tool tests could take advantage of this. |
pq
approved these changes
Jun 3, 2020
|
Regarding the changing public interface of Logger, should I bump the version to 0.2.0 in this PR? Next PR? |
|
This or a follow-up SGTM. Be sure and touch up the CHANGELOG while you're at it? |
|
Done! |
mosuem
pushed a commit
to dart-lang/tools
that referenced
this pull request
Oct 25, 2024
Add write() and writeCharCode() methods to Logger
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes dart-lang/tools#817
Adding public methods to subclassable public classes is a breaking change, for implementors, so I guess this should be a major version bump?