Skip to content
This repository was archived by the owner on Nov 1, 2024. It is now read-only.

Change verbose logging #31

Merged
merged 3 commits into from
May 16, 2018
Merged

Change verbose logging #31

merged 3 commits into from
May 16, 2018

Conversation

devoncarew
Copy link
Contributor

  • in verbose mode, instead of printing the diff from the last log message, print the total time since the tool started
  • change to not buffer the last log message sent in verbose logging mode
  • expose more classes from the logging library

@pq

pq
pq approved these changes May 16, 2018
View reviewed changes
Copy link
Contributor

@pq pq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

example/main.dart Outdated
@@ -21,5 +21,6 @@ main(List<String> args) async {
progress.finish(showTiming: true);

logger.stdout('All ${logger.ansi.emphasized('done')}.');
// ignore: deprecated_member_use
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is just going to get removed, maybe just remove it from the example?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@devoncarew devoncarew merged commit 352a8f8 into master May 16, 2018
@kevmoo kevmoo deleted the change_verbose_logging branch April 29, 2019 18:26
mosuem pushed a commit to dart-lang/tools that referenced this pull request Oct 25, 2024
@devoncarew
Merge pull request dart-archive/cli_util#31 from dart-lang/change_ver…
233d1ac 
…bose_logging

Change verbose logging
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
1 more reviewer

@pq pq pq approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
cla: yes
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@devoncarew @pq @googlebot