Skip to content

Cleanup Spring Dependencies #1334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 36 commits into from
May 29, 2025

Conversation

siri-varma
Copy link
Contributor

Description

  • I think having all the versions defined in the parent pom is a good idea.
  • Moved the versions for testcontainer-module and spring-boot-example to parent pom. Depending on the feedback from this PR will work on rest of the modules in later prs.

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #940

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

@siri-varma siri-varma requested review from a team as code owners May 5, 2025 21:09
Signed-off-by: siri-varma <[email protected]>
@siri-varma siri-varma marked this pull request as draft May 5, 2025 21:14
Copy link
Collaborator

@salaboy salaboy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@siri-varma I've left some comments .. I do recommend not having the springframework.version managed in this way.. it will make it really hard to maintain.

@siri-varma siri-varma marked this pull request as ready for review May 8, 2025 01:59
siri-varma added 8 commits May 8, 2025 10:50
Signed-off-by: siri-varma <[email protected]>
Signed-off-by: siri-varma <[email protected]>
Signed-off-by: siri-varma <[email protected]>
Signed-off-by: siri-varma <[email protected]>
Signed-off-by: siri-varma <[email protected]>
Signed-off-by: sirivarma <[email protected]>
@siri-varma siri-varma force-pushed the users/svegiraju/spring-pom-update branch from 40660c4 to 508148c Compare May 10, 2025 01:00
Signed-off-by: sirivarma <[email protected]>
@siri-varma
Copy link
Contributor Author

@salaboy addressed all your comments. Thank you

Copy link
Contributor

@artur-ciocanu artur-ciocanu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@siri-varma the PR looks good, but could you please provide some details why this is needed so I have a better high level understanding.

@siri-varma
Copy link
Contributor Author

@artur-ciocanu / @salaboy / @dapr-java-sdk-reveiwers PR is ready to be reviewed. Thank you

@siri-varma
Copy link
Contributor Author

@artur-ciocanu / @dapr-java-sdk-reviewer / @salaboy

Just a gentle reminder about this PR. Thank you

@artur-ciocanu
Copy link
Contributor

@siri-varma could you address the conflicts and resend the PR. Thank you!

@artur-ciocanu
Copy link
Contributor

@salaboy could you please take another look? From my perspective managing ALL the dependencies in a single place is a good idea. We used to have separate "code bases" for SDK and SDK tests, but almost a year ago I have added support for Maven profiles to be able to properly develop in an IDE.

So to recap I think moving all the deps to parent POM will allow us to upgrade more easily and have better control over dependencies.

@siri-varma
Copy link
Contributor Author

@artur-ciocanu resolved the comments. Thank you

@artur-ciocanu artur-ciocanu self-requested a review May 24, 2025 01:04
Copy link
Contributor

@artur-ciocanu artur-ciocanu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for all the effort! 🙇

@artur-ciocanu
Copy link
Contributor

@salaboy could you please take a look?

@salaboy
Copy link
Collaborator

salaboy commented May 28, 2025

@artur-ciocanu @siri-varma and @dapr/maintainers-java-sdk I think this is good to merge.. we need to try to define when to upgrade to 3.4.5 of spring boot. I need to check the pipelines to make sure that we are testing with that version.

@salaboy salaboy self-requested a review May 28, 2025 14:15
Copy link
Collaborator

@salaboy salaboy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@salaboy
Copy link
Collaborator

salaboy commented May 28, 2025

@dapr/maintainers-java-sdk please merge

@siri-varma
Copy link
Contributor Author

Thanks a lot everyone for the feedback and reviews

@siri-varma
Copy link
Contributor Author

@cicoyle / @artur-ciocanu This PR is ready to be merged.

Created a separate issue to track the flaky build

@dapr-bot dapr-bot merged commit c466d1b into dapr:master May 29, 2025
9 checks passed
Copy link

codecov bot commented May 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.17%. Comparing base (d759c53) to head (f52e021).
Report is 159 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1334      +/-   ##
============================================
+ Coverage     76.91%   78.17%   +1.25%     
- Complexity     1592     1831     +239     
============================================
  Files           145      223      +78     
  Lines          4843     5663     +820     
  Branches        562      601      +39     
============================================
+ Hits           3725     4427     +702     
- Misses          821      916      +95     
- Partials        297      320      +23     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

salaboy pushed a commit to salaboy/java-sdk that referenced this pull request May 29, 2025
* Update CONTRIBUTING.md

Signed-off-by: Siri Varma Vegiraju <[email protected]>

* Fix spring

Signed-off-by: siri-varma <[email protected]>

* Add context

Signed-off-by: siri-varma <[email protected]>

* Phase 1

Signed-off-by: siri-varma <[email protected]>

* Fix things

Signed-off-by: siri-varma <[email protected]>

* Fix things

Signed-off-by: siri-varma <[email protected]>

* Fix spring

Signed-off-by: siri-varma <[email protected]>

* Add context

Signed-off-by: siri-varma <[email protected]>

* Phase 1

Signed-off-by: siri-varma <[email protected]>

* Fix things

Signed-off-by: siri-varma <[email protected]>

* Fix things

Signed-off-by: siri-varma <[email protected]>

* move version

Signed-off-by: sirivarma <[email protected]>

* Fix pom

Signed-off-by: sirivarma <[email protected]>

* change version

Signed-off-by: sirivarma <[email protected]>

* remove unused

Signed-off-by: siri-varma <[email protected]>

* Address comments

Signed-off-by: siri-varma <[email protected]>

* Fix test

Signed-off-by: siri-varma <[email protected]>

* Fix test

Signed-off-by: siri-varma <[email protected]>

* Fix things

Signed-off-by: sirivarma <[email protected]>

---------

Signed-off-by: Siri Varma Vegiraju <[email protected]>
Signed-off-by: siri-varma <[email protected]>
Signed-off-by: sirivarma <[email protected]>
Co-authored-by: artur-ciocanu <[email protected]>
Signed-off-by: salaboy <[email protected]>
dapr-bot pushed a commit that referenced this pull request May 31, 2025
* adding remote endpoint request from inside activity with retry

Signed-off-by: salaboy <[email protected]>

* adding retry with Microcks payloads

Signed-off-by: salaboy <[email protected]>

* fixing review comments

Signed-off-by: salaboy <[email protected]>

* chore: New task execution task id test (#1352)

* chore: New task execution task id test

test how taskExecutionTaskId can be used for idempotency

Signed-off-by: Javier Aliaga <[email protected]>

* chore: Clean up not used files

Signed-off-by: Javier Aliaga <[email protected]>

* docs: Task execution keys

Signed-off-by: Javier Aliaga <[email protected]>

* test: Modify unit tests

Signed-off-by: Javier Aliaga <[email protected]>

* Remove new lines

Signed-off-by: artur-ciocanu <[email protected]>

---------

Signed-off-by: Javier Aliaga <[email protected]>
Signed-off-by: artur-ciocanu <[email protected]>
Co-authored-by: Cassie Coyle <[email protected]>
Co-authored-by: artur-ciocanu <[email protected]>
Signed-off-by: salaboy <[email protected]>

* Revert "chore: New task execution task id test (#1352)" (#1389)

This reverts commit 949584f.

Signed-off-by: Javier Aliaga <[email protected]>
Signed-off-by: salaboy <[email protected]>

* 1.5.5 (#1390)

Signed-off-by: Cassandra Coyle <[email protected]>
Signed-off-by: salaboy <[email protected]>

* Add Documentation for Conversation AI SDK (#1387)

Signed-off-by: salaboy <[email protected]>

* Cleanup Spring Dependencies (#1334)

* Update CONTRIBUTING.md

Signed-off-by: Siri Varma Vegiraju <[email protected]>

* Fix spring

Signed-off-by: siri-varma <[email protected]>

* Add context

Signed-off-by: siri-varma <[email protected]>

* Phase 1

Signed-off-by: siri-varma <[email protected]>

* Fix things

Signed-off-by: siri-varma <[email protected]>

* Fix things

Signed-off-by: siri-varma <[email protected]>

* Fix spring

Signed-off-by: siri-varma <[email protected]>

* Add context

Signed-off-by: siri-varma <[email protected]>

* Phase 1

Signed-off-by: siri-varma <[email protected]>

* Fix things

Signed-off-by: siri-varma <[email protected]>

* Fix things

Signed-off-by: siri-varma <[email protected]>

* move version

Signed-off-by: sirivarma <[email protected]>

* Fix pom

Signed-off-by: sirivarma <[email protected]>

* change version

Signed-off-by: sirivarma <[email protected]>

* remove unused

Signed-off-by: siri-varma <[email protected]>

* Address comments

Signed-off-by: siri-varma <[email protected]>

* Fix test

Signed-off-by: siri-varma <[email protected]>

* Fix test

Signed-off-by: siri-varma <[email protected]>

* Fix things

Signed-off-by: sirivarma <[email protected]>

---------

Signed-off-by: Siri Varma Vegiraju <[email protected]>
Signed-off-by: siri-varma <[email protected]>
Signed-off-by: sirivarma <[email protected]>
Co-authored-by: artur-ciocanu <[email protected]>
Signed-off-by: salaboy <[email protected]>

* network is needed

Signed-off-by: salaboy <[email protected]>

---------

Signed-off-by: salaboy <[email protected]>
Signed-off-by: Javier Aliaga <[email protected]>
Signed-off-by: artur-ciocanu <[email protected]>
Signed-off-by: Cassandra Coyle <[email protected]>
Signed-off-by: Siri Varma Vegiraju <[email protected]>
Signed-off-by: siri-varma <[email protected]>
Signed-off-by: sirivarma <[email protected]>
Co-authored-by: Javier Aliaga <[email protected]>
Co-authored-by: Cassie Coyle <[email protected]>
Co-authored-by: artur-ciocanu <[email protected]>
Co-authored-by: Siri Varma Vegiraju <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor maven POMs to put all information about the dependencies/plugins in the root POM
4 participants