Skip to content

state: add RavenDB support #3702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 49 commits into
base: main
Choose a base branch
from

Conversation

nmalocic
Copy link

@nmalocic nmalocic commented Mar 13, 2025

Added files related to RavenDB implementation from old branch for cleaner history

Description

Added support for RavenDB as state store.
Support for Set, Get, Delete and Multi interfaces.
Added conformance and certification tests

Issue reference

Please reference the issue this PR will close: #3318

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

@nmalocic nmalocic requested review from a team as code owners March 13, 2025 19:27
@elena-kolevska
Copy link
Contributor

elena-kolevska commented Mar 14, 2025

Hey @nmalocic thank you for your contribution!
Can you please sign your commits and check the failing tests?
https://github.com/dapr/components-contrib/pull/3702/checks

@daixiang0
Copy link
Member

@nmalocic could you use a more meaningful title?

@nmalocic nmalocic changed the title [3318]: RavenDB [3318]: Support RavenDB as state store Mar 14, 2025
@nmalocic nmalocic force-pushed the 3318-RavenDB-state-store-new branch from 31aa273 to 5064086 Compare March 14, 2025 09:58
@nmalocic
Copy link
Author

@elena-kolevska Commit is signed and now I see pending conformance tests, is there anything to fix before they are runned?

@daixiang0 Is title better now, should I also update description?

@daixiang0
Copy link
Member

@elena-kolevska Commit is signed and now I see pending conformance tests, is there anything to fix before they are runned?

@daixiang0 Is title better now, should I also update description?

Please remove issue number in the title, format as "state: add RavenDB support". Also update description.

@nmalocic nmalocic changed the title [3318]: Support RavenDB as state store state: add RavenDB support Mar 17, 2025
Copy link
Contributor

@elena-kolevska elena-kolevska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Patrick!
There's a lint error preventing cert tests to run.
Also, I didn't see the ravendb conformance test in the executed actions, it needs to be added in there (I think in the .github/scripts/test-info.mjs file). Check this pr for reference: #3588

@nmalocic nmalocic requested a review from elena-kolevska March 18, 2025 13:13
@nmalocic nmalocic force-pushed the 3318-RavenDB-state-store-new branch from 161c4e4 to 53fef16 Compare March 20, 2025 15:18
Copy link
Contributor

@elena-kolevska elena-kolevska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, just a few small things and also check the lint failures pls.
Great work!

nmalocic and others added 5 commits March 21, 2025 11:53
Co-authored-by: Elena Kolevska <[email protected]>
Signed-off-by: Nemanja Malocic <[email protected]>
Co-authored-by: Elena Kolevska <[email protected]>
Signed-off-by: Nemanja Malocic <[email protected]>
Co-authored-by: Elena Kolevska <[email protected]>
Signed-off-by: Nemanja Malocic <[email protected]>
Co-authored-by: Elena Kolevska <[email protected]>
Signed-off-by: Nemanja Malocic <[email protected]>
Copy link
Contributor

@elena-kolevska elena-kolevska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me and can be merged as soon as the licence key is removed from code and set as an env variable.

@cicoyle
Copy link
Contributor

cicoyle commented Mar 31, 2025

@nmalocic - mind running the linter locally and fixing the issues?

Signed-off-by: Nemanja Malocic <[email protected]>
@mikeee
Copy link
Member

mikeee commented Jul 30, 2025

/ok-to-test

@dapr-bot

This comment was marked as outdated.

@dapr-bot

This comment was marked as outdated.

@dapr-bot

This comment was marked as outdated.

Copy link
Member

@mikeee mikeee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this is the best way to sort out the env vars

@@ -832,6 +838,7 @@ const components = {
* @property {string?} nodeJsVersion If set, installs the specified Node.js version
* @property {string?} mongoDbVersion If set, installs the specified MongoDB version
* @property {string|string[]?} sourcePkg If set, sets the specified source package
* @property {boolean} requireRavenDBCredentials If true, sets RavenDB license environment variable
*/

/**
Copy link
Member

@mikeee mikeee Aug 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The matrix is generated minus the step to set the environment variable it'll need to be added.

(L845)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autoupdate automatically keeps PR up to date against master
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RavenDB as State store
10 participants