Fix #14064 Files are reanalyzed with --cppcheck-build-dir and inline suppressions (regression) #7741
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
firewave
reviewed
Aug 14, 2025
lib/suppressions.cpp
Outdated
| { | ||
| std::lock_guard<std::mutex> lg(mSuppressionsSync); | ||
|
|
||
| out << " <suppressions>" << std::endl; | ||
| for (const Suppression &suppression : mSuppressions) { | ||
| if (!filePath.empty() && !suppression.fileName.empty() && filePath != suppression.fileName) |
There was a problem hiding this comment.
As the suppression could contain a pattern we need to use the matching logic of the suppressions.
There was a problem hiding this comment.
Not sure I follow. There is only one suppression at a time, and we only care about inline suppressions.
|
Way to test the non-inline suppression case:
|
|
It is possible that |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.