Skip to content

format.yml: updated uncrustify to 0.80.1 #7421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 17 commits into from
May 7, 2025
Merged

format.yml: updated uncrustify to 0.80.1 #7421

merged 17 commits into from
May 7, 2025

Conversation

firewave
Copy link
Collaborator

@firewave firewave commented Apr 2, 2025

No description provided.

@firewave firewave force-pushed the uncrustify branch 4 times, most recently from aedd5bc to c93baa8 Compare April 2, 2025 10:18
@firewave
Copy link
Collaborator Author

firewave commented Apr 2, 2025

0.73.0 fails with

Parsing: lib/library.cpp as language CPP
terminate called after throwing an instance of 'std::out_of_range'
  what():  vector::_M_range_check: __n (which is 18446744073709551615) >= this->size() (which is 1)

@firewave

This comment was marked as resolved.

Sign in to view
firewave
firewave commented Apr 2, 2025
View reviewed changes
lib/programmemory.cpp
@@ -669,7 +669,7 @@ static ValueFlow::Value evaluate(const std::string& op, const ValueFlow::Value&
return result;
}

using BuiltinLibraryFunction = std::function<ValueFlow::Value(const std::vector<ValueFlow::Value>&)>;
using BuiltinLibraryFunction = std::function<ValueFlow::Value (const std::vector<ValueFlow::Value>&)>;
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks undesired.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes I agree it is undesired

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but imho it's not a blocker.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree. I just highlighted it out so I won't forget looking into it later on.

@firewave

This comment was marked as resolved.

Sign in to view
@firewave

This comment was marked as resolved.

Sign in to view
@firewave firewave force-pushed the uncrustify branch 5 times, most recently from 75ba613 to 856a9e8 Compare April 23, 2025 11:10
@firewave firewave changed the title format.yml: updated uncrustify format.yml: updated uncrustify to 0.80.1 Apr 23, 2025
@firewave firewave marked this pull request as ready for review May 6, 2025 16:01
@firewave
Copy link
Collaborator Author

firewave commented May 6, 2025

Still need to file a ticket for this.

danmar
danmar approved these changes May 7, 2025
View reviewed changes
lib/programmemory.cpp
@@ -669,7 +669,7 @@ static ValueFlow::Value evaluate(const std::string& op, const ValueFlow::Value&
return result;
}

using BuiltinLibraryFunction = std::function<ValueFlow::Value(const std::vector<ValueFlow::Value>&)>;
using BuiltinLibraryFunction = std::function<ValueFlow::Value (const std::vector<ValueFlow::Value>&)>;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but imho it's not a blocker.

@firewave firewave merged commit 3726ace into danmar:main May 7, 2025
53 checks passed
@firewave firewave deleted the uncrustify branch May 7, 2025 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danmar danmar danmar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@firewave @danmar