Skip to content

ENH: Unify and make subject more informative on new user notification emails #2246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

ENH: Unify and make subject more informative on new user notification emails #2246

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions dandiapi/api/mail.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,11 +96,12 @@ def send_ownership_change_emails(dandiset, removed_owners, added_owners):

def build_registered_message(user: User, socialaccount: SocialAccount):
# Email sent to the DANDI list when a new user logs in for the first time
greeting_name = user_greeting_name(user, socialaccount)
return build_message(
subject=f'DANDI: New user registered: {user.email}',
subject=f'DANDI: New user registered: {user.username} AKA {greeting_name} <{user.email}>)',
message=render_to_string(
'api/mail/registered_message.txt',
{'greeting_name': user_greeting_name(user, socialaccount)},
{'greeting_name': greeting_name},
),
to=[settings.DANDI_ADMIN_EMAIL, user.email],
)
Expand All @@ -119,8 +120,9 @@ def build_new_user_messsage(user: User, socialaccount: SocialAccount = None):
'username': user.username,
}
# Email sent to the DANDI list when a new user logs in for the first time
greeting_name = user_greeting_name(user, socialaccount)
return build_message(
subject=f'DANDI: Review new user: {user.username}',
subject=f'DANDI: Review new user: {user.username} AKA {greeting_name} <{user.email}>)',
message=render_to_string('api/mail/new_user_message.txt', render_context),
to=[settings.DANDI_ADMIN_EMAIL],
)
Expand Down
Loading