Added tab closing when process exists & app closes when no more tabs#13
Open
SelfMadeSystem wants to merge 2 commits intodahliaOS:mainfrom
Open
Added tab closing when process exists & app closes when no more tabs#13SelfMadeSystem wants to merge 2 commits intodahliaOS:mainfrom
SelfMadeSystem wants to merge 2 commits intodahliaOS:mainfrom
Conversation
larsb24
approved these changes
Mar 15, 2022
Member
|
I'm not sure if this would work well with the embdedded view inside pangolin. Can someone test this? |
Author
|
Did someone test this yet? |
Member
Hi, I just pushed a fix for the whole tab situation as the whole app was broken due to dependency changes etc. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Type of change
Please tick the relevant option by putting an X inside the bracket
(Bit of both I guess)
Checklist: