clamp to the edge #79
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Fil Sorry, is this PR abandoned or is it still awaiting review? |
|
Yes, please review 🙏 |
I don't believe I have the power, @mbostock please could this get blessed with a review 🙏? |
|
You don’t need any special power to test this PR against real life use
cases, read the code and try to find conditions that will make it break ,
etc. :)
|
|
@Fil I personally can't spot any issues but I wouldn't exactly call myself an expert on this. I'm using this for a work process and we can't use node/npm or any alternative (self-hosting the d3 UMD .js file in vanilla JS), so I can't build it myself either to test 😆 . |
|
@mbostock is there any chance you could please take a look/review this change? It's been outstanding for ~5 months. |
|
@Fil what's the plan here 😆 it would be really amazing if we could get this change in, do you know anyone who can review? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To avoid cutting the corners (#72), expand the data on the edges by 1 pixel (with the addition of a bit of blurring); then contract the shape back to the frame. Note that we must contract after smoothing.
closes #72