Skip to content

Conversation

tgriesser
Copy link
Member

User facing changelog

Consistently handle EPERM issues in chokidar watching

Additional details

Steps to test

How has the user experience changed?

PR Tasks

  • Have tests been added/updated?
  • Has the original issue (or this PR, if no issue exists) been tagged with a release in ZenHub? (user-facing changes only)
  • Has a PR for user-facing changes been opened in cypress-documentation?
  • Have API changes been updated in the type definitions?

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Jun 1, 2022

Thanks for taking the time to open a PR!

Copy link
Contributor

@flotwig flotwig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a way we can lint for this or otherwise enforce this? Otherwise this will regress next time someone adds a chokidar.watch.

Could wrap chokidar in a function that always passes ignorePermissionErrors

@cypress
Copy link

cypress bot commented Jun 1, 2022



Test summary

37553 0 454 0Flakiness 2


Run details

Project cypress
Status Passed
Commit 3bdaada
Started Jun 1, 2022 8:25 PM
Ended Jun 1, 2022 8:41 PM
Duration 15:31 💡
OS Linux Debian - 10.11
Browser Multiple

View run in Cypress Dashboard ➡️


Flakiness

cypress/e2e/cypress/proxy-logging.cy.ts Flakiness
1 Proxy Logging > request logging > xhr log has response body/status code when xhr response is logged second
2 Proxy Logging > request logging > xhr log has response body/status code when xhr response is logged second

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@tgriesser
Copy link
Member Author

Is there a way we can lint for this or otherwise enforce this? Otherwise this will regress next time someone adds a chokidar.watch.

@flotwig yeah definitely something we should look into for the future, in the meantime let's just go with this change for now

@tgriesser tgriesser merged commit f33eca8 into develop Jun 1, 2022
@tgriesser tgriesser deleted the tgriesser/fix/22002-add-fs-error-handlers branch June 1, 2022 20:49
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Jun 2, 2022

Released in 10.0.1.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v10.0.1, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Jun 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cypress v10 crashes with EPERM error
5 participants