[-] move to next envelope in Postgres sink if COPY fails, fixes #908#911
Merged
pashagolub merged 3 commits intomasterfrom Aug 27, 2025
Merged
[-] move to next envelope in Postgres sink if COPY fails, fixes #908#911pashagolub merged 3 commits intomasterfrom
COPY fails, fixes #908#911pashagolub merged 3 commits intomasterfrom
Conversation
When COPY fails sometimes `copyFromMeasurements.measurementIdx` is not incremented pointing to the measurement in the current envelope. But the loop awaits a next envelope and call to `copyFromMeasurements.MetricName()` tries to read the element beyond the limit.
pashagolub
added
bug
Pull Request Test Coverage Report for Build 17266774517Details
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When COPY fails sometimes
copyFromMeasurements.measurementIdxis not incremented pointing to the measurement in the current envelope. But the loop awaits a next envelope and call tocopyFromMeasurements.MetricName()tries to readthe element beyond the limit.