Skip to content

[-] remove host_config querying from GetSources()#863

Merged
pashagolub merged 1 commit intocybertec-postgresql:masterfrom
0xgouda:rm-host-cfg
Jul 25, 2025
Merged

[-] remove host_config querying from GetSources()#863
pashagolub merged 1 commit intocybertec-postgresql:masterfrom
0xgouda:rm-host-cfg

Conversation

@0xgouda
Copy link
Copy Markdown
Collaborator

@0xgouda 0xgouda commented Jul 24, 2025

Remove host_config querying from GetSources().

The reaper fails to read sources from postgres due to pgx.CollectRows[Source] in GetSources() giving error about missing host_config field from Source Struct

go run ./cmd/pgwatch --sources=postgres://postgres:postgres@localhost:5432/postgres --sink=jsonfile://file.json
2025-07-24 22:21:47.569 [ERROR] [error:struct doesn't have corresponding row field host_config] could not refresh active sources, using last valid cache
2025-07-24 22:21:47.571 [INFO] [metrics:73] [presets:17] metrics and presets refreshed

host_config field was removed from source in #859

@coveralls
Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 16505851832

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.007%) to 63.901%

Totals Coverage Status
Change from base Build 16501542019: -0.007%
Covered Lines: 3181
Relevant Lines: 4978

💛 - Coveralls

@pashagolub pashagolub self-assigned this Jul 25, 2025
@pashagolub pashagolub added the bug Something isn't working label Jul 25, 2025
@pashagolub pashagolub merged commit 2d23ff2 into cybertec-postgresql:master Jul 25, 2025
5 checks passed
@0xgouda 0xgouda deleted the rm-host-cfg branch August 1, 2025 02:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants