Skip to content

[-] fix Source.Equal() presets comparison, closes #830#831

Merged
pashagolub merged 2 commits intocybertec-postgresql:masterfrom
0xgouda:fix-src-equal
Jul 3, 2025
Merged

[-] fix Source.Equal() presets comparison, closes #830#831
pashagolub merged 2 commits intocybertec-postgresql:masterfrom
0xgouda:fix-src-equal

Conversation

@0xgouda
Copy link
Copy Markdown
Collaborator

@0xgouda 0xgouda commented Jul 2, 2025

ensure SourceConn.Equal() doesn't mark sources with empty presets as equal directly.
closes: #830

@coveralls
Copy link
Copy Markdown

coveralls commented Jul 2, 2025

Pull Request Test Coverage Report for Build 16015056674

Details

  • 13 of 13 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.4%) to 61.753%

Totals Coverage Status
Change from base Build 16007391230: 0.4%
Covered Lines: 2769
Relevant Lines: 4484

💛 - Coveralls

@pashagolub pashagolub self-assigned this Jul 3, 2025
@pashagolub pashagolub added bug Something isn't working sources What sources and in what way to monitor labels Jul 3, 2025
@pashagolub pashagolub changed the title [*] fix Source.Equal() presets comparison [-] fix Source.Equal() presets comparison, closes #830 Jul 3, 2025
@pashagolub pashagolub merged commit 1569fdd into cybertec-postgresql:master Jul 3, 2025
5 checks passed
@0xgouda 0xgouda deleted the fix-src-equal branch August 1, 2025 02:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working sources What sources and in what way to monitor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

sources that don't use presets can't get updated

3 participants