Skip to content

[*] fix Reap() to not require Source.MinDbSizeMb to be >= 8#818

Merged
pashagolub merged 1 commit intocybertec-postgresql:masterfrom
0xgouda:fix-mindbsize-handling
Jun 24, 2025
Merged

[*] fix Reap() to not require Source.MinDbSizeMb to be >= 8#818
pashagolub merged 1 commit intocybertec-postgresql:masterfrom
0xgouda:fix-mindbsize-handling

Conversation

@0xgouda
Copy link
Copy Markdown
Collaborator

@0xgouda 0xgouda commented Jun 24, 2025

remove if r.Sources.MinDbSizeMB >= 8 { check from Reap() method.

I tried to search the history for where this check was introduced but it wasn't added any time near so i don't know much about the context where it was added, so please do a check.

also the DbSizeMB != 0 check in if DBSizeMB != 0 && DBSizeMB < r.Sources.MinDbSizeMB is weird but i left it as is.

closes: #817

@coveralls
Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 15847267320

Details

  • 0 of 5 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 61.301%

Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/reaper/reaper.go 0 5 0.0%
Totals Coverage Status
Change from base Build 15821649882: 0.01%
Covered Lines: 2742
Relevant Lines: 4473

💛 - Coveralls

@pashagolub pashagolub merged commit 1581ee1 into cybertec-postgresql:master Jun 24, 2025
5 checks passed
@0xgouda 0xgouda deleted the fix-mindbsize-handling branch August 1, 2025 02:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

pgwatch don't process --min-db-size-mb values less than 8

3 participants