[*] exclude MetricDef from MeasurementEnvelope#787
Merged
pashagolub merged 1 commit intomasterfrom Jun 9, 2025
Merged
Conversation
pashagolub
added
metrics
Pull Request Test Coverage Report for Build 15536245462Details
💛 - Coveralls |
pashagolub
force-pushed
the
remove-metricdef-from-measurement
branch
from
0fc6638 to
a51dd7f
Compare
Sink doesn't need to know all information about metric so passing the whole definition is an overkill. This will decrease a memory consumption. Instead implement `MetricsDefiner` interface for sinks that needs metric specific information, e.g. gauges for Prometheus
pashagolub
force-pushed
the
remove-metricdef-from-measurement
branch
from
a51dd7f to
3cb6e11
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sink doesn't need to know all information about metric so passing the whole definition is an overkill. This will decrease a memory consumption