[+] define sync metric operations types as constants#781
Merged
pashagolub merged 2 commits intocybertec-postgresql:masterfrom Jun 4, 2025
Merged
[+] define sync metric operations types as constants#781pashagolub merged 2 commits intocybertec-postgresql:masterfrom
pashagolub merged 2 commits intocybertec-postgresql:masterfrom
Conversation
0xgouda
force-pushed
the
const-sync-operations
branch
from
2918156 to
83e78de
Compare
0xgouda
changed the title
Pull Request Test Coverage Report for Build 15438882202Details
💛 - Coveralls |
pashagolub
changed the title
pashagolub
added
enhancement
this adds AddOp DeleteOp constant operation types and invalidOp as unexported testing-only operation modifies rpc_test to be at the sinks package not sinks_test
pashagolub
force-pushed
the
const-sync-operations
branch
from
83e78de to
6dd8b5b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this adds
AddOp DeleteOpconstant operation typesand
invalidOpas unexported testing-only operation typemodifies sinks/rpc_test.go to be at the sinks package not sinks_test