[+] rewrite ParseLogs() with timers and eliminate extra checks#770
Merged
pashagolub merged 1 commit intomasterfrom May 30, 2025
Merged
[+] rewrite ParseLogs() with timers and eliminate extra checks#770pashagolub merged 1 commit intomasterfrom
ParseLogs() with timers and eliminate extra checks#770pashagolub merged 1 commit intomasterfrom
Conversation
Use `time.After()` instead of blocking `time.Sleep()`. Move preparation to the beginning of the function and do it only once. If configuration changes, reaper will destroy the current context and start another one with new configuration. No need to recalculate `csvlogRegex` and `logsGlobPath`. Add deferred latest handle closing. Add non-blocking send to sinks channel. Add unit tests.
Pull Request Test Coverage Report for Build 15347540095Details
💛 - Coveralls |
pashagolub
added
metrics
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use
time.After()instead of blockingtime.Sleep(). Move preparation to the beginning of the function and do it only once. If configuration changes, reaper will destroy the current context and start another one with new configuration. No need to recalculatecsvlogRegexandlogsGlobPath. Add deferred latest handle closing. Add non-blocking send to sinks channel. Add unit tests.