[*] release logrus.Entry immediately in BrokerHook.Fire()#1303
Merged
pashagolub merged 2 commits intomasterfrom Mar 16, 2026
Merged
[*] release logrus.Entry immediately in BrokerHook.Fire()#1303pashagolub merged 2 commits intomasterfrom
logrus.Entry immediately in BrokerHook.Fire()#1303pashagolub merged 2 commits intomasterfrom
Conversation
Format synchronously in `Fire()` while the entry is owned by the calling goroutine, send `MessageType` through the channel, and `send()` delivers out without `logrus.Entry` copy and without `lastError` channel
pashagolub
added
the
refactoring
Pull Request Test Coverage Report for Build 23142039709Details
💛 - Coveralls |
pashagolub
force-pushed
the
fix-log-broker-hook-entry-usage
branch
from
a403c2c to
d07dfcd
Compare
Contributor
|
Nice fix, moving the formatter into |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Format synchronously in
Fire()while the entry is owned by the calling goroutine, sendMessageTypethrough the channel, andsend()delivers out withoutlogrus.Entrycopy and withoutlastErrorchannel