[!] refactor Prometheus sink, closes #1267#1289
Merged
pashagolub merged 4 commits intomasterfrom Mar 11, 2026
Merged
Conversation
- send immediately without returning slice in `WritePromMetrics()` - add de-duplication for produced Prom metrics - use `NewConstMetric` instead of `MustNewConstMetric` - create cache snapshots during `Collect()` instead of clearing it, which safely enables parallel scrapes - sort label keys lexicographically to guarantee deterministic descriptor identities and avoid Prometheus "duplicate metric" errors - add unit tests
Pull Request Test Coverage Report for Build 22946701892Details
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WritePromMetrics()NewConstMetricinstead ofMustNewConstMetricCollect()instead of clearing it, which safely enables parallel scrapes