fix(webui): make metric SQLs readable with syntax highlighting#1282
Closed
Mohamed-Elfardy wants to merge 3 commits intocybertec-postgresql:masterfrom
Closed
fix(webui): make metric SQLs readable with syntax highlighting#1282Mohamed-Elfardy wants to merge 3 commits intocybertec-postgresql:masterfrom
Mohamed-Elfardy wants to merge 3 commits intocybertec-postgresql:masterfrom
Conversation
Collaborator
|
thanks for woking on this. Should it follow the color palette? It's kind of weird to have black theme for SQL surrounded by white theme |
Contributor
Author
Collaborator
|
duplicate of: #1280 plus why didn't you include the AI policy fields? |
Contributor
Author
i didn't duplicate anything from this pr even didn't see the changes on code he had done.
i will make sure from now to make the PRs include it. |
Collaborator
I didn't mean that you toke from him, but given that both of you didn't ask to work on it and that he sent his PR earlier, he has a higher priority. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Fixes #1241
The SQL queries displayed in the web ui were unreadable
so i
Added react-syntax-highlighter for dependency.
Replaced plain text rendering with SyntaxHighlighter component.
Used Light build to minimize bundle size.
Added wrapLongLines for better readability.
before:

after :
