[-] fix log parser to not re-read non-truncated files, fixes #1089#1168
Merged
pashagolub merged 5 commits intomasterfrom Feb 3, 2026
Merged
[-] fix log parser to not re-read non-truncated files, fixes #1089#1168pashagolub merged 5 commits intomasterfrom
pashagolub merged 5 commits intomasterfrom
Conversation
Also update mocks to expect the updated query
0xgouda
added
bug
Pull Request Test Coverage Report for Build 21622321915Details
💛 - Coveralls |
0xgouda
changed the title
3 tasks
Hamza-Azeem
pushed a commit
to Hamza-Azeem/pgwatch
that referenced
this pull request
Feb 3, 2026
…-postgresql#1089 (cybertec-postgresql#1168) * fix: don't re-read from start of the file if log truncation is off * Update tests to use new `tryDetermineLogsettings()` Also update mocks to expect the updated query * Set `maxTrackedFiles` to 2500 * Fix operators precedence * make linter happy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
map[string]uint64to track the last read offset for the file iflog_truncate_on_rotation= "off"maxTrackedFiles = 2500to avoid unbounded growth for the map tracking offsetsCloses #1089