Skip to content

[-] fix pgwatch_instance_up metric for down sources, closes #1158#1162

Merged
pashagolub merged 1 commit intomasterfrom
1158-fix-instance_up
Feb 2, 2026
Merged

[-] fix pgwatch_instance_up metric for down sources, closes #1158#1162
pashagolub merged 1 commit intomasterfrom
1158-fix-instance_up

Conversation

@pashagolub
Copy link
Copy Markdown
Collaborator

  • add table-driven test for GetInstanceUpMeasurement()
  • verify function never returns error regardless of connection state

- add table-driven test for `GetInstanceUpMeasurement()`
- verify function never returns error regardless of connection state
@pashagolub pashagolub self-assigned this Feb 2, 2026
@pashagolub pashagolub added bug Something isn't working metrics Metrics related issues labels Feb 2, 2026
@pashagolub pashagolub linked an issue Feb 2, 2026 that may be closed by this pull request
@coveralls
Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 21586329348

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 75.497%

Totals Coverage Status
Change from base Build 21580996158: 0.2%
Covered Lines: 4024
Relevant Lines: 5330

💛 - Coveralls

@pashagolub pashagolub merged commit 18ef642 into master Feb 2, 2026
13 of 14 checks passed
@pashagolub pashagolub deleted the 1158-fix-instance_up branch February 2, 2026 10:55
pashagolub added a commit that referenced this pull request Feb 2, 2026
…1162)

- add table-driven test for `GetInstanceUpMeasurement()`
- verify function never returns error regardless of connection state
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working metrics Metrics related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

pgwatch_instance_up prom metric wrong value

2 participants