Skip to content

[*] refactor reco_drop_index metric#1121

Merged
0xgouda merged 8 commits intomasterfrom
refactor-reco-drop-index-metric
Jan 16, 2026
Merged

[*] refactor reco_drop_index metric#1121
0xgouda merged 8 commits intomasterfrom
refactor-reco-drop-index-metric

Conversation

@0xgouda
Copy link
Copy Markdown
Collaborator

@0xgouda 0xgouda commented Jan 15, 2026 •
edited
Loading

  • Refactor reco_drop_index metric to measure duplicate indexes and return each index entry in a separate row
  • Remove measuring invalid/unused indexes from index_stats its now the responsibility of reco_drop_index

Updated index overview dashboard view:

image

Prometheus Recommendations dashboard:

image

Closes #1118

@0xgouda
Refactor reco_drop_index metric
56cef47 
Return duplicate indexes as well

Return each index entry in a separate row

Update `Duplicate Indexes`, `Unused Indexes`, and
`Invalid Indexes` panels in `Index overview` dashboard
to query it
@0xgouda
Use reco_drop_index for counting invalid/duplicate indexes in healt…
f55cd17 
…h check dashboard

instead of `index_stats`
@0xgouda
Some cleanup
dda2b37
@0xgouda
maintain some backward compatbility by using tag_object_name instea…
22a360a 
…d of `tag_index_full_name`
@0xgouda
Don't query unused/invalid indexes in index_stas metric
3e558d6 
This is now handled by `reco_drop_index` metric
@0xgouda
Specify gauges in reco_drop_index
353d95f
@coveralls
Copy link
Copy Markdown

coveralls commented Jan 15, 2026 •
edited
Loading

Pull Request Test Coverage Report for Build 21073024894

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 75.296%
Totals Coverage Status
Change from base Build 21071371678: 0.0%
Covered Lines: 4011
Relevant Lines: 5327
💛 - Coveralls

@0xgouda 0xgouda requested a review from pashagolub January 15, 2026 20:07
@0xgouda 0xgouda marked this pull request as ready for review January 15, 2026 20:07
@0xgouda 0xgouda added dashboards Grafana dashboards related metrics Metrics related issues refactoring Something done as it should've been done from the start labels Jan 15, 2026
@pashagolub pashagolub self-assigned this Jan 16, 2026
@pashagolub
Copy link
Copy Markdown
Collaborator

pashagolub commented Jan 16, 2026

#1123 causes conflicts here

pashagolub
pashagolub requested changes Jan 16, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@pashagolub pashagolub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

resolve conflicts, please

@0xgouda 0xgouda requested a review from pashagolub January 16, 2026 16:17
pashagolub
pashagolub approved these changes Jan 16, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@pashagolub pashagolub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@0xgouda 0xgouda merged commit 51a5e96 into master Jan 16, 2026
9 checks passed
@0xgouda 0xgouda deleted the refactor-reco-drop-index-metric branch January 16, 2026 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pashagolub pashagolub pashagolub approved these changes

Assignees

@pashagolub pashagolub

Labels

dashboards Grafana dashboards related metrics Metrics related issues refactoring Something done as it should've been done from the start

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Improvement for index stats metrics and dashboards

3 participants

@0xgouda @coveralls @pashagolub