Skip to content

[*] migrate all helpers to testutil#1071

Merged
0xgouda merged 15 commits intomasterfrom
migrate-all-helpers-to-testutil
Dec 9, 2025
Merged

[*] migrate all helpers to testutil#1071
0xgouda merged 15 commits intomasterfrom
migrate-all-helpers-to-testutil

Conversation

@0xgouda
Copy link
Copy Markdown
Collaborator

@0xgouda 0xgouda commented Dec 5, 2025


TODO:

  • Fix race condition that may originate from using SetupRPCServers() in tests multiple times.
  • Add more tests to increase test coverage.

@coveralls
Copy link
Copy Markdown

coveralls commented Dec 5, 2025

Pull Request Test Coverage Report for Build 20057289714

Details

  • 64 of 64 (100.0%) changed or added relevant lines in 2 files are covered.
  • 26 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.2%) to 73.807%

Files with Coverage Reduction New Missed Lines %
internal/testutil/setup.go 26 65.17%
Totals Coverage Status
Change from base Build 20057129747: -0.2%
Covered Lines: 3804
Relevant Lines: 5154

💛 - Coveralls

@0xgouda 0xgouda marked this pull request as draft December 5, 2025 18:38
The setup function should be invoked once across all tests
because it setups a global port listener,
otherwise running tests parallely
may fail with `address already in use` error.
@0xgouda 0xgouda added enhancement New feature or request test New test case or request labels Dec 8, 2025
@0xgouda 0xgouda self-assigned this Dec 8, 2025
@0xgouda 0xgouda marked this pull request as ready for review December 8, 2025 05:13
@0xgouda 0xgouda requested a review from pashagolub December 8, 2025 05:13
@pashagolub
Copy link
Copy Markdown
Collaborator

It's probably easier to start a new PR. I propose to focus only on docker container helpers first.

@0xgouda 0xgouda force-pushed the migrate-all-helpers-to-testutil branch from 27e6d46 to 9fd0919 Compare December 8, 2025 17:18
@0xgouda 0xgouda requested review from pashagolub December 8, 2025 17:33
Copy link
Copy Markdown
Collaborator

@pashagolub pashagolub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@0xgouda 0xgouda merged commit 759df3a into master Dec 9, 2025
9 checks passed
@0xgouda 0xgouda deleted the migrate-all-helpers-to-testutil branch December 9, 2025 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request test New test case or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants