Skip to content

[-] pin pgwatch-metrics data source to all panels and vars.#1053

Merged
pashagolub merged 3 commits intomasterfrom
sql_text_data_source
Dec 1, 2025
Merged

[-] pin pgwatch-metrics data source to all panels and vars.#1053
pashagolub merged 3 commits intomasterfrom
sql_text_data_source

Conversation

@df7cb
Copy link
Copy Markdown
Member

@df7cb df7cb commented Nov 28, 2025

This:

  1. Pins the pgwatch-metrics data source in all panels and vars in Grafana 12 postgres dashboards.
  2. Removes dummy "current": ... tags to ensure users with problems in data sources won't see weird hard-coded values.

The same for the Grafana 11 postgres dashboard will be done in a separate PR to avoid having a huge number of changed files = more potential for unintentionally breaking smth.

Otherwise the SQL gets run in whatever data source is configured as
default.
@df7cb
Copy link
Copy Markdown
Member Author

df7cb commented Nov 28, 2025

I did not bump any version numbers here, that should probably be done.

@coveralls
Copy link
Copy Markdown

coveralls commented Nov 28, 2025

Pull Request Test Coverage Report for Build 19822098050

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 73.648%

Totals Coverage Status
Change from base Build 19765583712: 0.0%
Covered Lines: 3678
Relevant Lines: 4994

💛 - Coveralls

@df7cb
Copy link
Copy Markdown
Member Author

df7cb commented Nov 28, 2025

More dashboard with the same problem:

  • $dbname in 4-tables-overview
  • pgbouncer-stats: $monitoredsource

Useful when user has a datasource error, we shouldn't show him
arbitary default values from our own builds.
- Additionally, remove unnecessary `"current": ...` tags.
@0xgouda 0xgouda force-pushed the sql_text_data_source branch from 5ba6184 to 86022eb Compare December 1, 2025 12:07
@0xgouda 0xgouda changed the title Pin $sql_text to the pgwatch-metrics data source [*] pin pgwatch-metrics data source to all panels and vars. Dec 1, 2025
@0xgouda 0xgouda added bug Something isn't working dashboards Grafana dashboards related labels Dec 1, 2025
@0xgouda 0xgouda requested a review from pashagolub December 1, 2025 12:18
@0xgouda 0xgouda changed the title [*] pin pgwatch-metrics data source to all panels and vars. [-] pin pgwatch-metrics data source to all panels and vars. Dec 1, 2025
Copy link
Copy Markdown
Collaborator

@pashagolub pashagolub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@pashagolub pashagolub self-assigned this Dec 1, 2025
@pashagolub pashagolub merged commit 5c0a652 into master Dec 1, 2025
9 checks passed
@pashagolub pashagolub deleted the sql_text_data_source branch December 1, 2025 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working dashboards Grafana dashboards related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants