-
Notifications
You must be signed in to change notification settings - Fork 672
Adapt to the new interface for pycolmap 3.12 #467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hello, I wanted to note that you need to set the following line to As pycolmap no longer supports the original line. |
With the latest updates the Aachen evaluation works again |
I can also confirm that the InLoc pipeline works again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much for the work!
About the notebook: there is an empty cell at the end, can you remove it? The notebook is also much larger than the previous one (9MB vs 2MB), can we reduce it?
Fixed this, the plotly visualizations were still in the output. Now we are back to 2MB. Side-note: I also changed the default extractor to ALIKED. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, feel free to merge!
Thank you so much! @Phil26AT |
Reopening #446 from the official repo.
Fixes #460
Fixes #445
Fixes #440
Fixes #438