Skip to content

Adapt to the new interface for pycolmap 3.12 #467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 25 commits into from
Jul 22, 2025
Merged

Conversation

B1ueber2y
Copy link
Member

@B1ueber2y B1ueber2y commented Jul 4, 2025

Reopening #446 from the official repo.

Fixes #460
Fixes #445
Fixes #440
Fixes #438

@ayoussf
Copy link

ayoussf commented Jul 4, 2025

Hello,

I wanted to note that you need to set the following line to
poses[q] = (ret["cam_from_world"].rotation.quat[[3, 0, 1, 2]], ret["cam_from_world"].translation)

As pycolmap no longer supports the original line.

@Phil26AT
Copy link
Collaborator

Phil26AT commented Jul 4, 2025

With the latest updates the Aachen evaluation works again

@Phil26AT
Copy link
Collaborator

I can also confirm that the InLoc pipeline works again.

@Phil26AT Phil26AT requested a review from sarlinpe July 21, 2025 08:30
Copy link
Member

@sarlinpe sarlinpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for the work!

About the notebook: there is an empty cell at the end, can you remove it? The notebook is also much larger than the previous one (9MB vs 2MB), can we reduce it?

@Phil26AT
Copy link
Collaborator

Thank you very much for the work!

About the notebook: there is an empty cell at the end, can you remove it? The notebook is also much larger than the previous one (9MB vs 2MB), can we reduce it?

Fixed this, the plotly visualizations were still in the output. Now we are back to 2MB. Side-note: I also changed the default extractor to ALIKED.

Copy link
Member

@sarlinpe sarlinpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, feel free to merge!

@B1ueber2y
Copy link
Member Author

Thank you so much! @Phil26AT

@Phil26AT Phil26AT merged commit 2e2a551 into master Jul 22, 2025
1 check passed
@Phil26AT Phil26AT deleted the features/fix_pycolmap branch July 22, 2025 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants