Add scope type parser piece of custom command grammar #2295
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pokey
changed the title
pokey
force-pushed
the
pokey/add-scope-type-parser-of-custom-command-grammar
branch
3 times, most recently
from
43395f8 to
64fbaea
Compare
pokey
commented
Apr 16, 2024
There was a problem hiding this comment.
basically nothing changed in this file; just pulled out some utils from the keyboard parser to use for this new parser, and did slight renames to remove references to the word "keyboard"
pokey
force-pushed
the
pokey/add-scope-type-parser-of-custom-command-grammar
branch
from
64fbaea to
ba53a81
Compare
pokey
commented
Apr 16, 2024
There was a problem hiding this comment.
This was the other half of packages/cursorless-engine/src/util/grammarHelpers.ts
the piece that is keyboard-specific
pokey
force-pushed
the
pokey/add-scope-type-parser-of-custom-command-grammar
branch
3 times, most recently
from
a546856 to
e89aa20
Compare
AndreasArvidsson
approved these changes
Apr 18, 2024
pokey
force-pushed
the
pokey/add-scope-type-parser-of-custom-command-grammar
branch
from
6b3dc62 to
130f9b4
Compare
|
@josharian This technically needs a review from you because it touches keyboard directory. The change there is completely incidental; I just moved some code out of there into the engine so we could use it for new custom command parser |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial work towards #492; will be used to parse scope types in #2131
Exposes a function
parseScopeTypethat can parse strings likefunk,curlyetc into their corresponding scope type payloadsHere's a railroad: https://deploy-preview-2295--cursorless.netlify.app/custom-command-railroad
Checklist