Skip to content

Conversation

lowener
Copy link
Contributor

@lowener lowener commented Mar 22, 2024

This PR closes #7699. It is adding support for SPGEMM ALG2 of cusparse that requires a much lower memory usage than the default, used only when the default algorithm would fail.

@leofang
Copy link
Member

leofang commented Mar 22, 2024

Q: Is there a way we can test the new code path? Maybe you can add a known problem size to the test suite?

@takagi takagi self-assigned this Mar 25, 2024
@takagi takagi added cat:enhancement Improvements to existing features prio:medium labels Mar 25, 2024
@lowener
Copy link
Contributor Author

lowener commented Mar 25, 2024

I added a test to do spgemm on matrices (100k x 50 - 50 x 100k).
This problem size triggers the usage of the lower memory algorithm on my RTX 3070Ti (8GB) and on my Quadro RTX 8000 (48GB).
I disabled the element-wise comparison with scipy on this problem size to not slow down the CI.

@leofang
Copy link
Member

leofang commented Mar 30, 2024

/test mini

@takagi
Copy link
Contributor

takagi commented Apr 5, 2024

/test mini

@takagi takagi added this to the v14.0.0a1 milestone Apr 5, 2024
@takagi takagi enabled auto-merge April 5, 2024 04:06
takagi
takagi previously approved these changes Apr 5, 2024
Copy link
Contributor

@takagi takagi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@takagi
Copy link
Contributor

takagi commented Apr 5, 2024

/test full

@takagi
Copy link
Contributor

takagi commented Apr 5, 2024

Let me kick the full test to check with older CTKs.

@takagi
Copy link
Contributor

takagi commented Apr 10, 2024

Would you check the result of static-checks and fix it?
https://github.com/cupy/cupy/actions/runs/8510603439/job/23642667154?pr=8252

auto-merge was automatically disabled April 10, 2024 09:45

Head branch was pushed to by a user without write access

@takagi
Copy link
Contributor

takagi commented Apr 11, 2024

Copy link
Contributor

@takagi takagi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@takagi takagi merged commit 8d86eb7 into cupy:main Apr 11, 2024
@lowener lowener deleted the spgemm-mem branch April 13, 2024 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cat:enhancement Improvements to existing features prio:medium
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use different cuSparse algorithm for SpGEMM
3 participants