Skip to content

Skip CUDA_PATH warning in Conda installation #8051

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 4, 2024
Merged

Skip CUDA_PATH warning in Conda installation #8051

merged 1 commit into from
Jan 4, 2024

Conversation

kmaehashi
Copy link
Member

@kmaehashi kmaehashi changed the title Skip CUDA_PATH warning in Conda installatoin Skip CUDA_PATH warning in Conda installation Dec 25, 2023
@kmaehashi kmaehashi marked this pull request as ready for review December 25, 2023 05:58
@emcastillo emcastillo self-assigned this Dec 26, 2023
@emcastillo emcastillo added cat:install Build and installation to-be-backported Pull-requests to be backported to stable branch labels Dec 26, 2023
@emcastillo emcastillo added this to the v14.0.0a1 milestone Dec 26, 2023
@jakirkham
Copy link
Member

Thanks Kenichi! 🙏

As this is a simple change, do you think we could get this in 13.0.0?

No worries if not. Just wanted to check 🙂

@kmaehashi
Copy link
Member Author

@jakirkham Yes, no concerns regarding backport!

@kmaehashi kmaehashi added the blocking Issue/pull-request is mandatory for the upcoming release label Dec 28, 2023
@kmaehashi
Copy link
Member Author

/test mini

@leofang
Copy link
Member

leofang commented Jan 3, 2024

Refs conda-forge/cupy-feedstock#206 (comment)

Searching get_cuda_path and get_nvcc_path (which internally calls get_cuda_path) in the codebase, I see it's been used for multiple purposes:

  • Find nvcc (compiler.py)
  • Find CUDA headers (core.pyx et al)
  • Find cudadevrt (compiler.py)
  • Find CUDA binary utils (callback.pyx)
  • ...

I think this PR should be merged, and in the meanwhile we consider how to better support different package layouts, since the time of all-in-one CUDA installation is fading 🙂

@emcastillo emcastillo merged commit 60242bb into cupy:main Jan 4, 2024
chainer-ci pushed a commit to chainer-ci/cupy that referenced this pull request Jan 4, 2024
@chainer-ci
Merge pull request cupy#8051 from kmaehashi/fix-unnecessary-warning
278bae6 
Skip `CUDA_PATH` warning in Conda installation
@chainer-ci chainer-ci mentioned this pull request Jan 4, 2024
Merged
@jakirkham
Copy link
Member

Thanks all! 🙏

Also happy new year! 🥳

@kmaehashi kmaehashi deleted the fix-unnecessary-warning branch January 4, 2024 08:37
@leofang leofang mentioned this pull request Jan 5, 2024
Open
@jakirkham jakirkham mentioned this pull request Feb 8, 2024
Closed
@kmaehashi kmaehashi mentioned this pull request Aug 22, 2024
Merged
@kmaehashi kmaehashi mentioned this pull request Feb 26, 2025
Merged
@kmaehashi kmaehashi mentioned this pull request Jun 26, 2025
Merged
@kmaehashi kmaehashi mentioned this pull request Aug 15, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
2 more reviewers

@leofang leofang leofang approved these changes

@emcastillo emcastillo emcastillo approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@leofang leofang

@emcastillo emcastillo

Labels
blocking Issue/pull-request is mandatory for the upcoming release cat:install Build and installation prio:medium to-be-backported Pull-requests to be backported to stable branch
Projects
None yet
Milestone
v14.0.0a1
Development

Successfully merging this pull request may close these issues.
4 participants
@kmaehashi @jakirkham @leofang @emcastillo