Support for break and continue keywords #8010
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asi1024
reviewed
Dec 1, 2023
| y[:mask] += 1 | ||
| assert bool((x == y).all()) | ||
|
|
||
| def test_break_and_continue(): |
There was a problem hiding this comment.
Sure thing, ill push the change in a few hours when I'm back
There was a problem hiding this comment.
Tests are split, also added a non-static break/continue condition to each just in case the compiler can optimize static ones away.
Co-authored-by: Akifumi Imanishi <[email protected]>
Co-authored-by: Akifumi Imanishi <[email protected]>
|
/test mini |
|
My bad, I still don't have a proper testing env set up yet, so the copied over tests didn't have the "self" parameter. Should work now |
|
/test mini |
|
/test mini |
|
/test mini |
asi1024
approved these changes
Dec 19, 2023
|
@Zhyrek LGTM! Thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows functions with "break" and "continue" keywords to be compiled by @jit.rawkernel
Added a test to cupy/tests/cupyx_tests/jit_tests/test_raw.py for both keywords, in both for and while loops.