Skip to content

Conversation

kmaehashi
Copy link
Member

This eliminates the following warnings:

cpdef variables will not be supported in Cython 3; currently they are no different from cdef variables

@kmaehashi kmaehashi added cat:code-fix Code refactoring that do not change behavior prio:medium to-be-backported Pull-requests to be backported to stable branch labels May 27, 2021
@emcastillo emcastillo modified the milestone: v10.0.0a1 May 27, 2021
@asi1024
Copy link
Member

asi1024 commented May 27, 2021

Jenkins, test this please.

@asi1024 asi1024 added the st:test-and-merge (deprecated) Ready to merge after test pass. label May 27, 2021
@asi1024 asi1024 added this to the v10.0.0a2 milestone May 27, 2021
@chainer-ci
Copy link
Member

Jenkins CI test (for commit 59858fa, target branch master) succeeded!

@mergify mergify bot merged commit 09c9e3c into cupy:master May 27, 2021
chainer-ci pushed a commit to chainer-ci/cupy that referenced this pull request May 27, 2021
Use cdef instead of cpdef where appropraite
@kmaehashi kmaehashi deleted the remove-cython-warnings branch May 27, 2021 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cat:code-fix Code refactoring that do not change behavior prio:medium st:test-and-merge (deprecated) Ready to merge after test pass. to-be-backported Pull-requests to be backported to stable branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants