Skip to content

Conversation

emcastillo
Copy link
Member

@emcastillo emcastillo commented Mar 9, 2021

Backport of #4363

There were several conflicts so I expect this to need additional work.

@emcastillo emcastillo added backport Pull-requests backported from development branch cat:bug Bugs prio:high labels Mar 9, 2021
@emcastillo
Copy link
Member Author

[automatic post] Jenkins, test this please.

@emcastillo emcastillo added this to the v8.6.0 milestone Mar 9, 2021
@chainer-ci
Copy link
Member

Jenkins CI test (for commit bb042b2, target branch v8) failed with status FAILURE.

@emcastillo
Copy link
Member Author

Jenkins, test this please

@chainer-ci
Copy link
Member

Jenkins CI test (for commit 0a12f63, target branch v8) succeeded!

Copy link
Member

@toslunar toslunar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except for the line.

Co-authored-by: Toshiki Kataoka <[email protected]>
@emcastillo
Copy link
Member Author

Jenkins, test this please

@chainer-ci
Copy link
Member

Jenkins CI test (for commit f054799, target branch v8) succeeded!

@toslunar toslunar added the st:test-and-merge (deprecated) Ready to merge after test pass. label Mar 10, 2021
@mergify mergify bot merged commit f70089d into cupy:v8 Mar 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Pull-requests backported from development branch cat:bug Bugs prio:high st:test-and-merge (deprecated) Ready to merge after test pass.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants