-
-
Notifications
You must be signed in to change notification settings - Fork 687
Generate lib/cucumber/messages_pb.rb on install #715
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
From what I've need, yes, it will provide the |
This should avoid trouble when installing, for example if bash is not available. The makefile should only be used during development, for released version the file is there and nothing should be done.
The idea was to avoid having to load the shell (for example for people using the gem on Windows). But maybe a simpler solution would be to use:
instead of:
This way we don't need bash at all. That said I'm not sure this would work at all when installing the gem on windows. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed in a week if no further activity occurs. |
This is related to #813 |
Will this approach work if the user doesn't have |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed in a week if no further activity occurs. |
This issue has been automatically closed because of inactivity. You can support the Cucumber core team on opencollective. |
Summary
gem cucumber-messages can not be installed from git as the file lib/cucumber/messages_pb.rb is not checked-out.
This ensures that the file is created.
Still TO-DO:
rake build && gem install pkg/cucumber-messages-*.gem
and ensure it does not fail)Details
Motivation and Context
This should allow us to reference the gem from the GIT repo when working on
cucumber-ruby
orcucumber-ruby-core
.How Has This Been Tested?
Badly for now, see TODO section.
Types of changes
Not applicable.
Checklist: