Fix : Create_subarray typo

[guillaumegrolleron]

reference_location is now properly transmitted

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.37%. Comparing base (2b31ca5) to head (fb3bbaf).
⚠️ Report is 7 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main      #73   +/-   ##
=======================================
  Coverage   85.37%   85.37%           
=======================================
  Files           7        7           
  Lines         937      937           
=======================================
  Hits          800      800           
  Misses        137      137           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[jlenain]

Hi @guillaumegrolleron ,

Thanks for this, but I think the original implementation is correct. Here reference_location is not defined anywhere.
Instead, nectarcam_location is defined as one of the constants in ctapipe_io_nectarcam.constants, and is properly imported in __init__.

Was it causing a problem on your side ?

[jlenain]

Hi @jlenain,

Indeed, it was not causing any trouble, I just saw the potential problem

Hi @guillaumegrolleron ,

Thanks for this, but I think the original implementation is correct. Here reference_location is not defined anywhere. Instead, nectarcam_location is defined as one of the constants in ctapipe_io_nectarcam.constants, and is properly imported in __init__.

Was it causing a problem on your side ?

Oh my bad. Now I see what you mean: we indeed need to pass to SubarrayDescription the argument which was provided in the first place to the create_subarray method.

My apologies, you are right.