-
Notifications
You must be signed in to change notification settings - Fork 17
Add reading of calibration files in fits format #238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #238 +/- ##
==========================================
+ Coverage 90.97% 91.03% +0.05%
==========================================
Files 25 25
Lines 2637 2688 +51
==========================================
+ Hits 2399 2447 +48
- Misses 238 241 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
You need to rebase or merge with main. This also needs tests with the fits files produced by lstcam-calib. |
it tells it is already up to date |
| def test_to_native(): | ||
| from ctapipe_io_lst.calibration import to_native | ||
|
|
||
| assert to_native(np.array([1, 2], dtype='>i4')).dtype=='int32' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This only tests the case where the array is not yet native and it also doesn't verify that the values are actually correct.
Ah, sorry, right. The fix for the CI is not yet merged, this PR is needed, please review: |
@maxnoe, I need to add fits calibration and drs4 baseline files, but it seems that that the other test data are in lstchain, what do you suggest to do? |
0e88a35 to
5188636
Compare
|
I decided at the end to create only one test for all parameters |
This is necessary in order to move to fits output as requested by EvB