bumped dataframes version #92
Conversation
|
I don't understand why https://travis-ci.org/github/cstjean/ScikitLearn.jl/jobs/744241946#L188 says v.0.22.0, but https://travis-ci.org/github/cstjean/ScikitLearn.jl/jobs/744241946#L296 says 0.21.8. And I don't get why it fails on 1.4 but succeeds on nightly 😢 |
|
Gah, this stuff is so annoying. Presumably will need to at least wait for this. Particularly aggravating because it's only used in tests. |
|
RDatasets 0.7.2 now supports DataFrames 0.22. |
|
Ok, so there's some |
|
Ok, I found the failure and fixed it. I've also taken the liberty to switch the latest travis run from 1.4 to 1.5. Let's see if it passes. |
| @@ -8,7 +8,7 @@ env: | |||
| - PYTHON=Conda | |||
| julia: | |||
| - 1.0 | |||
| - 1.4 | |||
| - 1.5 | |||
There was a problem hiding this comment.
yeah, I keep forgetting that, I only recently realized that putting 1 gives latest 1. Let's see what the test result is and I'll put it in.
|
There was a failure on mac. Looks full-blown dependency hell involving GaussianMixtures and StatsBase |
|
Offf, I don't know what the right solution is to this. GaussianMixtures is just a test dependency, so technically, 1.0 might still work perfectly well. Unless someone has a bright idea, I'd say we drop Julia 1.0 support in the name of sanity. 1.6 will be LTS anyway, right? |
|
Looks like the resolver got lost in the requirements on Compat imposed by GaussianMixtures and ScikitLearn. Maybe you could try requiring |
|
Alright, I tried that, let's see how it goes. |
|
Failures are due to GaussianMixtures not supporting StatsBase 0.33. It supports it on master but no release has been tagged since then. I've asked at davidavdav/GaussianMixtures.jl#68. |
|
Though you could try tweaking only the Compat bounds instead. |
|
Ok, I tried triggering this again (by bumping the PyCall version) and am just sort of hoping that everything miraculously works now because of changes in other packages. |
|
@cstjean, I don't see much in the way of DataFrames here other than in |
|
Yes, the DataFrames support should be confined to |
|
I'm not yet confident that it won't be breaking, but I am confident it won't be very breaking. Ideally would like to merge this PR before taking that on, but it's still breaking because GaussianMixtures needs a tag. |
If that would help, I would be fine merging this with |
|
It's up to you of course, but there's no good reason why the compat issue can't just be fixed, so maybe let's wait a bit longer. I tried to make noise about this in various places today. |
|
JuliaRegistries/General#25016 was opened, but it requires manual merging. Make some noise there, that could help! |
|
See also davidavdav/GaussianMixtures.jl#81. |
|
OK, GaussianMixtures has been tagged. Should be good to start another CI run. |
|
Looks like it's passing. For some reason travis now seems to wait for mac to finish before it runs linux, which I find rather irritating. |
|
Ok, passing, finally. @cstjean , please merge when you get a chance? Finally I think this is the last major package holding back DataFrames 0.22 |
|
Thank you for this PR! |
|
No problem! Also, don't forget we'll need a tag. Thanks! |
Don't think any of the changes should affect this package.
Note that, in the long run, it would probably be best to remove DataFrames as a dependency in favor of the Tables interface, but I didn't look into how involved that would be.