Fixes issue with wrong numbers printing to console in csound for iOS #97
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… iOS I was running into issues when using the supplied code snippet for printing to the Xcode console from iOS using swift. It seems like the extra step for creating a CVaListPointer was messing something (not sure what) up. However, when just using info.valist directly, this works. As I do not exactly understand why this extra code was there, somebody who knows should check if my change is breaking something. I deleted the corresponding mention of the now deleted extra code in the manual text, too.
jase5
commented
Sep 28, 2024
| ) | ||
| vsnprintf(message, 1024, info.format, va_ptr) | ||
|
|
||
| vsnprintf(message, 1024, info.format, info.valist) | ||
| let messageStr = String(cString: message) | ||
| print(messageStr) |
There was a problem hiding this comment.
Also, the memory for buffer should be deallocated in the end to prevent excessive memory use:
message?.deallocate()
|
A similar fix was approved here: nikhilsinghmus/CsoundiOS_SwiftExamples#1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was running into issues when using the supplied code snippet for printing to the Xcode console from iOS using swift. Most numbers were completely off, usually extremely high or negative.
It seems like the extra step for creating a CVaListPointer was messing something (not sure what) up. However, when just using info.valist directly, this works. As I do not exactly understand why this extra code was there, somebody who knows should check if my change is breaking something that I am unaware of! As I understand it, the valist in the csound message is already compatible with vsnprintf().
I deleted the corresponding mention of the now deleted extra code in the manual text, too.