Add DS compiler to Nintendo worker #20
Conversation
|
Thank you very much for sending an update for the worker! I’m busy with release stuff right now so probably will not be able to get back to this until the release is finished. After that point, please bug me if I do not get to this promptly. |
| @@ -81,7 +106,8 @@ RUN apt-get update && \ | |||
|
|
|||
| ENV DEVKITPRO=/opt/devkitpro | |||
| ENV DEVKITPPC=$DEVKITPRO/devkitPPC | |||
| ENV PATH=$PATH:$DEVKITPPC/bin:$DEVKITPPC/powerpc-eabi/bin | |||
| ENV DEVKITARM=$DEVKITPRO/devkitARM | |||
| ENV PATH=$PATH:$DEVKITPPC/bin:$DEVKITPPC/powerpc-eabi/bin:$DEVKITARM/bin:$DEVKITARM/arm-none-eabi/bin | |||
There was a problem hiding this comment.
This won’t work right if the build code is well-behaved, since the DS compiler will pick up package configurations from devkitPPC first. It’s probably best to just split the DS and Wii into two workers if we’re going to keep supporting DS.
| "ds": { | ||
| "configure_args": [ | ||
| "--host=ds", | ||
| "--enable-mad", |
There was a problem hiding this comment.
Prefer feature detection over explicitly passing feature flags like this, so that our releases are as consistent as possible across platforms. If the detection is broken such that an explicit flag is needed, that probably means something else is broken too.
| wget \ | ||
| bzip2 | ||
|
|
||
| RUN wget -O devkitARMupdate.pl 'https://sourceforge.net/projects/devkitpro/files/Automated Installer/devkitARMupdate.pl/download' && \ |
There was a problem hiding this comment.
Is there any way to do this which is reproducible?
This requires the changes from scummvm/scummvm#1057