Skip to content

add grid component #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Oct 10, 2019
Merged

add grid component #20

merged 6 commits into from
Oct 10, 2019

Conversation

esyw
Copy link
Contributor

@esyw esyw commented Oct 6, 2019

No description provided.

@esyw esyw requested a review from gawdn October 6, 2019 14:14
@esyw esyw self-assigned this Oct 6, 2019
gawdn
gawdn suggested changes Oct 6, 2019
View reviewed changes
Copy link
Contributor

@gawdn gawdn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks mostly good - well done! 👍
I've left a few points to look at - when you address them re-request my review and I'll approve.

@esyw esyw requested a review from gawdn October 9, 2019 02:03
gawdn
gawdn approved these changes Oct 10, 2019
View reviewed changes
Copy link
Contributor

@gawdn gawdn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done!

@gawdn gawdn merged commit a9535ed into dev Oct 10, 2019
@delete-merged-branch delete-merged-branch bot deleted the feat/grid branch October 10, 2019 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gawdn gawdn gawdn approved these changes

Assignees

@esyw esyw

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@esyw @gawdn