Skip to content

Fix missing home greeting component #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 6, 2019
Merged

Fix missing home greeting component #19

merged 1 commit into from
Oct 6, 2019

Conversation

gawdn
Copy link
Contributor

@gawdn gawdn commented Oct 3, 2019

Changes

  • Fix left over code to allow HomeGreeting component to load correctly

Change reason

Fixes component

Comments

None

Closes

None

Checklist

  • PR is named appropriately (describe what it does/changes/fixes)
  • Changes are "atomic" (related to the same thing) otherwise consider splitting your PR into two changes
  • You have linked the issues this PR closes by using Close #issue_number
  • You have assigned this PR to yourself (or as appropriate)
  • You have assigned reviewers to the PR
  • You have labelled this PR appropriately
  • You have set the project and milestone
  • You have rebased this PR against the remote base branch using git rebase -i origin/dev (other relevant base branch). Read the contributing guide if you're unsure.

@gawdn gawdn requested review from elizabethzhong and esyw October 3, 2019 10:53
@gawdn gawdn self-assigned this Oct 3, 2019
@esyw esyw merged commit 2e0108c into dev Oct 6, 2019
@delete-merged-branch delete-merged-branch bot deleted the fix/base-image branch October 6, 2019 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants