Skip to content

[Intrinsics] Fix incorrect _vxarq_u64 intrisic #1222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jschneider-bensch merged 3 commits into from
Nov 3, 2025
Merged

[Intrinsics] Fix incorrect _vxarq_u64 intrisic #1222

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1e1f4fe
[Intrinsics] Fix incorrect `_vxarq_u64` intrisic
jschneider-bensch Nov 3, 2025
1157385
[ML-KEM/ML-DSA] Add ARM64 runners to CI
jschneider-bensch Nov 3, 2025
9b30806
[CI] Fix `EXCLUDE_FEATURES` to respect ARM64 Linux target
jschneider-bensch Nov 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/mldsa-build-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ jobs:
- macos-13 # Intel mac
- macos-latest # macos-15 on apple silicon
- ubuntu-latest
- ubuntu-24.04-arm
- windows-latest
exclude:
- bits: 32
Expand Down
5 changes: 3 additions & 2 deletions .github/workflows/mlkem-build-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ jobs:
os:
- macos-latest # macos-15 on apple silicon
- ubuntu-latest
- ubuntu-24.04-arm
- windows-latest
exclude:
- bits: 32
Expand All @@ -47,10 +48,10 @@ jobs:
if: ${{ matrix.bits == 64 }}

- run: echo 'EXCLUDE_FEATURES=--exclude-features simd256' > $GITHUB_ENV
if: ${{ matrix.os == 'macos-latest' }}
if: ${{ matrix.os == 'macos-latest' || matrix.os == 'ubuntu-24.04-arm' }}

- run: echo 'EXCLUDE_FEATURES=--exclude-features simd128' > $GITHUB_ENV
if: ${{ matrix.os != 'macos-latest' }}
if: ${{ matrix.os != 'macos-latest' && matrix.os != 'ubuntu-24.04-arm' }}

- name: 🛠️ Setup Rust Nightly
run: rustup toolchain install nightly
Expand Down
5 changes: 4 additions & 1 deletion libcrux-intrinsics/src/arm64.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -438,7 +438,10 @@ pub fn _vxarq_u64<const LEFT: i32, const RIGHT: i32>(a: uint64x2_t, b: uint64x2_
)))]
{
let a_xor_b = _veorq_u64(a, b);
_veorq_u64(_vshlq_n_u64::<LEFT>(b), _vshrq_n_u64::<RIGHT>(a_xor_b))
_veorq_u64(
_vshlq_n_u64::<LEFT>(a_xor_b),
_vshrq_n_u64::<RIGHT>(a_xor_b),
)
}
}

Expand Down
Loading