Conversation
|
@mmetc: There are no area labels on this PR. You can add as many areas as you see fit.
DetailsI am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository. |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #3910 +/- ##
==========================================
- Coverage 61.61% 61.58% -0.04%
==========================================
Files 405 405
Lines 41782 41789 +7
==========================================
- Hits 25744 25735 -9
- Misses 13916 13927 +11
- Partials 2122 2127 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| err = plan.Execute(ctx, interactive, dryRun, showPlan, verbosePlan) | ||
| switch { | ||
| case errors.Is(err, hubops.ErrUserCanceled): | ||
| case errors.Is(err, hubops.ErrUserCanceled) && err != nil: |
There was a problem hiding this comment.
I dont understand this case, if errors.Is is true that means the err is not nil or is there a case when it can? 🤷🏻
There was a problem hiding this comment.
yes but nilaway doesn't know/handle this automatically so we must be more explicit. it's one of the false positives that is worth to fix to finally enable the linter.
No description provided.