Skip to content

lapi: return specific error if a unix socket path is too long for the OS#3593

Merged
mmetc merged 1 commit into
masterfrom
unix-socket-path-maxlength
Apr 29, 2025
Merged

lapi: return specific error if a unix socket path is too long for the OS#3593
mmetc merged 1 commit into
masterfrom
unix-socket-path-maxlength

Conversation

@mmetc
Copy link
Copy Markdown
Contributor

@mmetc mmetc commented Apr 29, 2025

give the user a hint on what's happening (nothing more we can do) and make sure the tests don't fail for the same reason.

@mmetc mmetc added the kind/enhancement New feature or request label Apr 29, 2025
@mmetc mmetc added this to the 1.6.9 milestone Apr 29, 2025
@github-actions
Copy link
Copy Markdown

@mmetc: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area appsec
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 29, 2025

Codecov Report

Attention: Patch coverage is 71.42857% with 4 lines in your changes missing coverage. Please review.

Project coverage is 57.66%. Comparing base (a79b92f) to head (ca36baf).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
pkg/csnet/socket.go 75.00% 3 Missing ⚠️
pkg/acquisition/modules/appsec/appsec.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3593      +/-   ##
==========================================
- Coverage   57.67%   57.66%   -0.01%     
==========================================
  Files         394      395       +1     
  Lines       43969    43981      +12     
==========================================
+ Hits        25359    25362       +3     
- Misses      16474    16480       +6     
- Partials     2136     2139       +3     
Flag Coverage Δ
bats 42.63% <71.42%> (-0.01%) ⬇️
unit-linux 32.83% <0.00%> (-0.01%) ⬇️
unit-windows 22.34% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mmetc mmetc force-pushed the unix-socket-path-maxlength branch 2 times, most recently from f3026ac to 26aecae Compare April 29, 2025 09:17
@mmetc mmetc force-pushed the unix-socket-path-maxlength branch from 26aecae to ca36baf Compare April 29, 2025 09:18
@mmetc mmetc requested a review from LaurenceJJones April 29, 2025 10:35
Copy link
Copy Markdown
Contributor

@LaurenceJJones LaurenceJJones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mmetc mmetc merged commit 7891268 into master Apr 29, 2025
15 checks passed
@mmetc mmetc deleted the unix-socket-path-maxlength branch April 29, 2025 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/enhancement New feature or request needs/area

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants