chore(deps): update dependencies#488
Merged
sergenyalcin merged 3 commits intocrossplane:mainfrom Apr 28, 2025
Merged
Conversation
fdc0c46 to
1f63c07
Compare
Contributor
Author
|
These changes work along with the changes from this PR: crossplane/crossplane-tools#86 |
b0eadd2 to
c47b21e
Compare
Contributor
Author
|
cc/ @negz since you merged crossplane/crossplane-tools#86 |
Update crossplane-runtime and k8s.io dependencies Fix linting errors as well. Signed-off-by: Duologic <jeroen@simplistic.be>
9eb2a03 to
1ab8089
Compare
Contributor
Author
|
Ah, I see, #458 got merged, fixing a few things that this PR was handling as well. I rebased. |
| @@ -11,7 +11,7 @@ require ( | |||
| github.com/alecthomas/kingpin/v2 v2.4.0 | |||
| github.com/antchfx/htmlquery v1.2.4 | |||
| github.com/crossplane/crossplane v1.18.0 | |||
Collaborator
There was a problem hiding this comment.
nit: might crossplane/crossplane bump this to 1.19.1 as well
Signed-off-by: Duologic <jeroen@simplistic.be>
014b4a8 to
32c1230
Compare
Signed-off-by: Duologic <jeroen@simplistic.be>
sergenyalcin
approved these changes
Apr 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
Update crossplane-runtime and k8s.io dependencies
Fix linting errors as well.
Replaces #452(replaced by #458, merged)Depends on crossplane/crossplane-tools#86 (using replace in go.mod)(merged)I have:
make reviewableto ensure this PR is ready for review.How has this code been tested
I'm working on this in relation to using it in https://github.com/grafana/crossplane-provider-grafana/
I've used this in grafana/crossplane-provider-grafana#273