Decouple conversion webhook registration from leader election - #357
Merged
ulucinar merged 1 commit intoJul 29, 2026
Merged
Conversation
- Bump github.com/crossplane/upjet/v2 to v2.3.0, whose setup aggregator template emits SetupWebhookWithManager. Signed-off-by: Alper Rifat Ulucinar <ulucinar@users.noreply.github.com>
ulucinar
requested review from
erhancagirici,
jonasz-lasut,
sergenyalcin and
turkenf
as code owners
July 28, 2026 22:28
Collaborator
Author
|
/test-examples="examples/cluster/applications/v1beta2/application.yaml" |
erhancagirici
approved these changes
Jul 29, 2026
erhancagirici
left a comment
erhancagirici
left a comment
Collaborator
There was a problem hiding this comment.
thanks @ulucinar, LGTM
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
Related PRs: crossplane-contrib/provider-upjet-aws#2122
Applies the upjet template fix for the conversion webhook / leader election bug to this provider. It also bumps upjet to
v2.3.0.cmd/provider/main.go: removesStartWebhooksfrom both opts structs; adds an explicitstartWebhooksblock before thecanSafeStartgate that callsSetupWebhookWithManagerfor both cluster-scoped and namespaced controllers. A comment at the call site explains why webhook registration must happen here rather than inside the gate.config/templates/controller.go.tmpl: mirrors the upjet template change — addsSetupWebhookWithManager, removes theif o.StartWebhooks { ... }block fromSetup.I have:
make reviewableto ensure this PR is ready for review.How has this code been tested