docs(containerapp): fix CustomDomain certificate field descriptions - #1285
Merged
jonasz-lasut merged 1 commit intoAug 10, 2026
Merged
Conversation
jonasz-lasut
requested review from
erhancagirici,
jastang,
sergenyalcin,
turkenf and
ulucinar
as code owners
August 10, 2026 06:16
The CustomDomain CRD described certificate_binding_type and container_app_environment_certificate_id as immutable, but upbound/terraform-provider-azurerm#6 made them updatable in place. Only clearing the certificate (switching to an Azure Managed certificate) still forces a new resource, via a scoped CustomizeDiff. The descriptions are scraped into config/provider-metadata.yaml from the hashicorp upstream docs on every `make generate`, while the provider itself is the upbound fork, so the corrected text has to be applied in the resource configurator to survive regeneration. Signed-off-by: Jonasz Łasut-Balcerzak <jonasz@upbound.io>
jonasz-lasut
force-pushed
the
containerapp-docs
branch
from
August 10, 2026 06:18
728c41b to
be1e674
Compare
sergenyalcin
approved these changes
Aug 10, 2026
sergenyalcin
left a comment
sergenyalcin
left a comment
Collaborator
There was a problem hiding this comment.
Thanks @jonasz-lasut LGTM!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
Update docs for CustomDomain.containerapp to match the removed ForceNew
I have:
make reviewableto ensure this PR is ready for review.### How has this code been tested