add username to rds connection details - #475
Merged
Merged
Conversation
Signed-off-by: josephferrero <joeferrero14@gmail.com>
|
|
ytsarev
approved these changes
Jan 31, 2023
ytsarev
left a comment
ytsarev
left a comment
Contributor
There was a problem hiding this comment.
LGTM, thanks a lot for your contribution.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: josephferrero joeferrero14@gmail.com
Description of your changes
Added
usernameto the RDS instance connection secret.Fixes #442 for the request to add the username to the connection secret. Note that the port is now included in the endpoint address, so it is not required to achieve feature parity with the
database.aws.crossplane.io/v1beta1provider.I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
I have run
make local-deployand created an RDS instance in AWS to test creation of the secret.