Fix ec2: TransitGatewayRouteTablePropagation inverted transit_gateway_attachment_id and transit_gateway_route_table_idids - #438
Merged
Conversation
|
|
AlexDouze
changed the title
TransitGatewayRouteTablePropagation inverted transit_gateway_attachment_id and transit_gateway_route_table_idids
Contributor
Author
|
/test-examples="examples/ec2/transitgatewayroutetablepropagation.yaml" |
Collaborator
|
/test-examples="examples/ec2/transitgatewayroutetablepropagation.yaml" |
sergenyalcin
approved these changes
Jan 23, 2023
sergenyalcin
left a comment
sergenyalcin
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for this fix @AlexDouze LGTM!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
I inverted the
transit_gateway_attachment_idandtransit_gateway_route_table_idin theaws_ec2_transit_gateway_route_table_propagationexternal name. Because IDs were inverted as suspected in #434Fixes #434
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
I deployed the freshly built provider in my setup, it created the expected
TransitGatewayRouteTablePropagation.